Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7033: Home Open button should remember last opened location #15323

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jun 18, 2024

Purpose

Task: https://jira.autodesk.com/browse/DYN-7033

Open on homepage will now point to the last opened workspace location instead of the samples directory. It will point to the samples directory until a workspace is opened for a particular location.

homepage open

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Home Open button should remember last opened location

Reviewers

@QilongTang

@github-actions github-actions bot changed the title Home Open button should remember last opened location DYN-7033: Home Open button should remember last opened location Jun 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7033

@QilongTang QilongTang added this to the 3.3 milestone Jun 18, 2024
@QilongTang
Copy link
Contributor

Nice

@reddyashish
Copy link
Contributor Author

@QilongTang unit test is getting tricky to add for this particular case. Probably a UI test would suit better. Would like to get this change in without a test now.

Copy link

github-actions bot commented Jun 18, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang
Copy link
Contributor

Hi @reddyashish Would you ship it and cherry-pick? I think although this is a small improvement, it would be bothering without it for the release. Also, would you add a gif?

@reddyashish
Copy link
Contributor Author

yeah added a gif, cherrypick to 3.2.1?

@QilongTang
Copy link
Contributor

yeah added a gif, cherrypick to 3.2.1?

Yes, please

@reddyashish
Copy link
Contributor Author

@reddyashish reddyashish merged commit e6a32f9 into DynamoDS:master Jun 18, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants