Cherry Pick DYN-7103, DYN-7127 Fix crash error in Instancing Rendering logic, Fix issue with code block rendering #15313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue with code block rendering (DynamoDS#15296) (cherry picked from commit df3a852)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7103
aparajit-pratap
approved these changes
Jun 13, 2024
QilongTang
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cherry pick of #15296
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fixed an issue where Dynamo would crash when rendering the background preview with the instancing turned on.
Fixed an issue where code blocks did not render geometry correctly to the background preview with instancing turned on.
Reviewers
@aparajit-pratap @QilongTang
FYIs
@jnealb @avidit