DYN-7055 Library view initialization crash #15307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7055
QilongTang
commented
Jun 11, 2024
| double zoomFactor = ((double)dynamoViewModel.Model.PreferenceSettings.LibraryZoomScale / 100d); | ||
|
|
||
| //The default value of the zoom factor is 1.0. The value that comes from the slider is in percentage, so we divide by 100 to be equivalent | ||
| browser.ZoomFactor = (double)dynamoViewModel.Model.PreferenceSettings.LibraryZoomScale / 100; |
There was a problem hiding this comment.
The ZoomFactor is calculated twice, this is also fixed
reddyashish
approved these changes
Jun 11, 2024
pinzart90
reviewed
Jun 11, 2024
pinzart90
reviewed
Jun 11, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
pinzart90
reviewed
Jun 11, 2024
pinzart90
approved these changes
Jun 11, 2024
|
@QilongTang were we able to reproduce this crash ? |
I was not able to reproduce it, the fix is based on CER report (without steps included) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Per https://jira.autodesk.com/browse/DYN-7055, library view initialization could crash at the end of it by looking at the call stacks from v3.0.3,
see https://github.com/DynamoDS/Dynamo/blob/RC3.0.3_master/src/LibraryViewExtensionWebView2/LibraryViewController.cs#L397C34-L397C51
According to the callstack, it would be worth to put more code into the try-catch in the function than just the navigate function
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix a potential Library view initialization crash on Dynamo 3.0.3
Reviewers
@DynamoDS/dynamo
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of