Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7071: better hierarchy of Graph Elements Scale settings #15286

Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Jun 5, 2024

Purpose

This PR addresses the following concern raised by this ticket https://forum.dynamobim.com/t/dynamo-setting-graphic-elements-scale/101595/2?u=jacob.small. The issue is tracked here https://jira.autodesk.com/browse/DYN-7071 As a Dynamo user, I want a better hierarchy of Graph Elements Scale settings

UI Changes

image description

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • change location of the toggle for better user experience

Reviewers

@QilongTang

FYIs

@Amoursol

- change location of the toggle for better user experience
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7071

Copy link

github-actions bot commented Jun 5, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.3 milestone Jun 5, 2024
@QilongTang
Copy link
Contributor

@QilongTang
Copy link
Contributor

@QilongTang QilongTang merged commit 01a8539 into DynamoDS:master Jun 5, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants