DYN-6856 Import settings from splash screen should handle empty file content. #15279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6856
QilongTang
reviewed
Jun 4, 2024
| @@ -1087,7 +1087,7 @@ public static PreferenceSettings LoadContent(string content) | |||
| PreferenceSettings settings = null; | |||
|
|
|||
| if(string.IsNullOrEmpty(content)) | |||
| return new PreferenceSettings(); | |||
| return new PreferenceSettings() { isCreatedFromValidFile = false }; | |||
There was a problem hiding this comment.
hmm I guess you chose to not touch constructor since it should be true there?
There was a problem hiding this comment.
yeah the default constructor should be true as we import the default settings when no file is selected explicitly.
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-6856
Preferences settings Import from splash screen should show an error when an empty xml file is imported.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
DYN-6856 Import settings from splash screen should handle empty file content.
Reviewers
@QilongTang @avidit