Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6840: add new boundary condition node #15270
DYN-6840: add new boundary condition node #15270
Changes from 1 commit
8322d70
86eb823
18c603c
830c1df
144813b
e917df1
1df7c03
a728944
b485390
a4ba1f5
8689c68
b3bca71
154ca1c
a010721
25ce1e0
bb788b1
54e9220
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just make this singular like the enum itself -
PanelSurfaceBoundaryCondition
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PanelSurfaceBoundaryCondition will collide with the ENum coming from ProtoGeom (at least in the library view)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aparajit-pratap is the layout spec good enough for now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move the other
PanelSurfaceBoundaryCondition
node under this newBoundaryCondition
category as well? I think more than one node can have the same name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe there's a special setting to allow same name nodes under the same parent ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or I can change the name of the new node (again)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe only the same named nodes are allowed if and only if they have different inputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Amoursol what do you think about the layout above ? 2 entries with the same name "PanelSurfaceBoundaryCOndition"
ONe is a dropdown node, the other is category (I think) for individual boundaryCOndition nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pinzart90 As it's still experimental, I don't think layoutspec changes matter too much. So we can do any of those changes and evaluate later if need be.
On the name front, could we please name it "Select Boundary Condition"? This is similar to some Revit paradigms. Do we also need to mark it an Action, not a Query?
Probably not plural - unlike image. Sorry on that miss!