Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6840: add new boundary condition node #15270
DYN-6840: add new boundary condition node #15270
Changes from 15 commits
8322d70
86eb823
18c603c
830c1df
144813b
e917df1
1df7c03
a728944
b485390
a4ba1f5
8689c68
b3bca71
154ca1c
a010721
25ce1e0
bb788b1
54e9220
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an enum based dropdown...
https://github.com/DynamoDS/DynamoRevit/blob/bcb122017c2e5ebe63e4198f8b8f84a3abc5305a/src/Libraries/RevitNodesUI/GenericClasses.cs#L128
maybe it makes sense to move that class here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also an EnumBase class inside Dynamo, but it generates the string values not the actual enum types.
Dynamo/src/Libraries/CoreNodeModels/Enum.cs
Line 39 in 0b23a2e
I guess they could all be made into a more generic class. I would consolidate them in another task
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.