Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6135: Use new feature flag for ML data ingestion pipeline #15262

Merged
merged 2 commits into from
May 29, 2024
Merged

DYN-6135: Use new feature flag for ML data ingestion pipeline #15262

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d2d15
Use new feature flag for ML data ingestion pipeline
reddyashish May 29, 2024
a6493f6
Update DynamoViewModel.cs
reddyashish May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/DynamoCoreWpf/ViewModels/Core/DynamoViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
using System.IO;
using System.Linq;
using System.Reflection;
using System.Runtime.Loader;
using System.Threading.Tasks;
using System.Windows;
using System.Windows.Controls;
Expand Down Expand Up @@ -207,6 +206,7 @@ public WorkspaceModel CurrentSpace
get { return model.CurrentWorkspace; }
}

[Obsolete("This flag is not needed anymore and can be removed.")]
reddyashish marked this conversation as resolved.
Show resolved Hide resolved
/// <summary>
/// Controls if the the ML data ingestion pipeline is beta from feature flag
/// </summary>
Expand All @@ -218,6 +218,17 @@ internal bool IsMLDataIngestionPipelineinBeta
}
}

/// <summary>
/// Controls if the the ML data ingestion pipeline is beta from feature flag
/// </summary>
internal bool IsDNADataIngestionPipelineinBeta
{
get
{
return DynamoModel.FeatureFlags?.CheckFeatureFlag("IsDNADataIngestionPipelineinBeta", true) ?? true;
}
}

/// <summary>
/// Count of unresolved issues on the linter manager.
/// This is used for binding in the NotificationsControl
Expand Down Expand Up @@ -3005,7 +3016,7 @@ private void CloseHomeWorkspace(object parameter)
// Upon closing a workspace, validate if the workspace is valid to be sent to the ML datapipeline and then send it.
if (!DynamoModel.IsTestMode && !HomeSpace.HasUnsavedChanges && (currentWorkspaceViewModel?.IsHomeSpace ?? true) && HomeSpace.HasRunWithoutCrash)
{
if (!IsMLDataIngestionPipelineinBeta && Model.CurrentWorkspace.IsValidForFDX && currentWorkspaceViewModel.Checksum != string.Empty)
if (!IsDNADataIngestionPipelineinBeta && Model.CurrentWorkspace.IsValidForFDX && currentWorkspaceViewModel.Checksum != string.Empty)
{
if (HasDifferentialCheckSum())
{
Expand Down
Loading