Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7033: distinct recent files #15260

Merged
merged 2 commits into from
May 29, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 29, 2024

Purpose

References https://jira.autodesk.com/browse/DYN-7033 Same graphs opened twice appear twice on AppHome.

Note: it is still possible to show the same graph name saved in multiple file locations. For details, user can utilize the List view in the HomePage.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now explicitly filters out duplicate recent graphs based on location (cannot add the same graph twice to the list of recent graphs)
  • note: still possible to have the same graph saved in multiple locations

Reviewers

@avidit
@reddyashish

FYIs

@Amoursol

- now explicitly filters out duplicate recent graphs based on location (cannot add the same graph twice to the list of recent graphs)
- note: still possible to have the same graph saved in multiple locations
@github-actions github-actions bot changed the title distinct recent files DYN-7033: distinct recent files May 29, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7033

Copy link

github-actions bot commented May 29, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.2 milestone May 29, 2024
@reddyashish
Copy link
Contributor

The self-serve timed out. Running it again to verify the issue.

@reddyashish reddyashish merged commit 71b18b0 into DynamoDS:master May 29, 2024
24 checks passed
@reddyashish
Copy link
Contributor

Will cherrypick this once testing is done.

reddyashish pushed a commit to reddyashish/Dynamo that referenced this pull request May 29, 2024
@reddyashish reddyashish mentioned this pull request May 29, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants