Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN- 6893 input and output nodes should not show in home workspace. #15257

Merged
merged 5 commits into from
May 29, 2024

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented May 28, 2024

Purpose

see original PR here for more info:
#15204

Screenshot 2024-05-28 at 1 04 25 PM
Screenshot 2024-05-28 at 1 04 22 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

😢 - AFAIK this will need to be tested with integration tests - @avidit do we have any tests that do image comparisons or html comparisons of the library?

Release Notes

fix a legacy issue where input and output symbol nodes were shown in the HomeWorkspace context even though they are only useful in CustomNodeWorkspaces.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6893

Copy link

github-actions bot commented May 28, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@avidit
Copy link
Contributor

avidit commented May 28, 2024

We did have tests to compare items in the library but due to lack of TestComplete's support for webview2, the tests are not running at the moment.

Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
var type = workspace switch
{
HomeWorkspaceModel _ => "home",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of having an enum instead of a hard-coded string?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be straight forward, will look into it.

@mjkkirschner
Copy link
Member Author

We did have tests to compare items in the library but due to lack of TestComplete's support for webview2, the tests are not running at the moment.

would it be crazy to implement dumping the library to html and then doing our own snapshotting in the meantime?

@avidit
Copy link
Contributor

avidit commented May 28, 2024

We did have tests to compare items in the library but due to lack of TestComplete's support for webview2, the tests are not running at the moment.

would it be crazy to implement dumping the library to html and then doing our own snapshotting in the meantime?

We should do something like that as we are not sure when will TestComplete support webview2

@mjkkirschner mjkkirschner merged commit 2b36e1f into DynamoDS:master May 29, 2024
23 of 24 checks passed
@mjkkirschner mjkkirschner deleted the dyn-6893-contextState branch July 8, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants