-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN- 6893 input and output nodes should not show in home workspace. #15257
DYN- 6893 input and output nodes should not show in home workspace. #15257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6893
UI Smoke TestsTest: success. 2 passed, 0 failed. |
We did have tests to compare items in the library but due to lack of TestComplete's support for webview2, the tests are not running at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
{ | ||
var type = workspace switch | ||
{ | ||
HomeWorkspaceModel _ => "home", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of having an enum instead of a hard-coded string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be straight forward, will look into it.
would it be crazy to implement dumping the library to html and then doing our own snapshotting in the meantime? |
We should do something like that as we are not sure when will TestComplete support webview2 |
Purpose
see original PR here for more info:
#15204
Declarations
Check these if you believe they are true
*.resx
files😢 - AFAIK this will need to be tested with integration tests - @avidit do we have any tests that do image comparisons or html comparisons of the library?
Release Notes
fix a legacy issue where input and output symbol nodes were shown in the HomeWorkspace context even though they are only useful in CustomNodeWorkspaces.