DYN-6995 Crash When Changing Language #15254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This problem is happening only in Dynamo Revit and happens due that the DynamoCore.dll is not being localized when inserting a graph (which contains a group) is trying to find a default group with a localized name but is not found then is making the code to crash. With this fix I'm forcing to assign a group even when the default group is not found.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6995
|
GIF before my fix when inserting the graph is crashing |
|
GIF after my fix. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
May 28, 2024
|
Given the common crash reason, please also cherry-pick to RC3.2 branch |
RobertGlobant20
added a commit
to RobertGlobant20/Dynamo
that referenced
this pull request
May 28, 2024
9 tasks
reddyashish
pushed a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Dynamo for Revit crashing when inserting a graph after the language was changed
This problem is happening only in Dynamo Revit and happens due that the DynamoCore.dll is not being localized when inserting a graph (which contains a group) is trying to find a default group with a localized name but is not found then is making the code to crash. With this fix I'm forcing to assign a group even when the default group is not found.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo for Revit crashing when inserting a graph after the language was changed
Reviewers
@QilongTang
FYIs