DYN-6991 crash report groups change #15239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When moving groups inside Dynamo there was a crash but is not reproducible based in the information from the Report and Stack trace. Then with this validation we are validating that is not null and if is null then try to set the ViewModelBases again.
Adding code for just preventing the crash, there is no way to reproduce the steps done by the user and the report stacktrace doesn't give enough detail for this crash.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6991
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Dynamo Crash when the ViewModelBases is null
By checking the StackTrace of this report the System.Linq.ThrowHelper.ThrowArgumentNullException is send when trying to execute the next Linq instruction:
ViewModelBases.OfType<AnnotationViewModel>().ToList().ForEach(x => UpdateGroupCutGeometry(x));So when ViewModelBases is null the exception is thrown.
I was trying to reproduce the behavior adding groups, group inside groups, moving the groups and nodes inside it but the crash was not generated then by checking the code the only way that ViewModelBases could be null is if the AnnotationModel doesn't contain the nodes/connectors in WorkspaceViewModel but this scenario was not reproducible.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Dynamo Crash when the ViewModelBases is null
Reviewers
@QilongTang
FYIs
@pinzart90 @avidit