DYN-6927: Improvements to RemovePIIData API #15236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6927
QilongTang
reviewed
May 22, 2024
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
reviewed
May 22, 2024
QilongTang
approved these changes
May 22, 2024
QilongTang
reviewed
May 22, 2024
| //result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, ipPattern, ""); | ||
| result = Regex.Replace(result, creditCardPattern, ""); | ||
| result = Regex.Replace(result, websitePattern, ""); |
There was a problem hiding this comment.
hi @reddyashish So the trick is to just change the order of regex?
There was a problem hiding this comment.
The main change is to use RemovePIIData(JObject jsonObject) API on the whole json object which will look for the regex pattern in the Views, Annotations etc.
There was a problem hiding this comment.
Right, in the past we are running the regex against the text?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-6927
Using the RemovePIIData(JObject jsonObject), we check for the regex patterns in specific parts like the VIew or Annotations section of the JSON to remove the personal sensitive data.
It should remove email pattern, SSN number pattern, credit card pattern, user directory pattern, IP address pattern, date patterns and website patterns.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
DYN-6927: Improvements to RemovePIIData API to accurately remove only the sensitive personal info.
Reviewers
@QilongTang @zeusongit
FYIs
@DynamoDS/dynamo