Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6633: Definedata bugfix heterogenous lists #15235

Merged
merged 10 commits into from
May 22, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 21, 2024

Purpose

  • Bug fix to the node - fixed a bug where evaluating lists would allow incompatible data to be validated
  • Minor code refactoring - extracted function to return data after validation (to databridge callback)
  • New test added - checks all Warnings we throw
  • Introduced a custom function to safely extract dictionary values to resolve a 'non-pointer exception' being added after a throw from function

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed a bug where incompatible lists would be allowed
  • added test to check all error conditions
  • code cleanup

Reviewers

@twastvedt
@mjkkirschner
@saintentropy

FYIs

@Amoursol

dnenov and others added 7 commits May 19, 2024 10:31
- update to ui to match latest design intent
- removed redundant code
- introduced new `BooleanNegationConverter` (how was that not needed before) to flip the value of a boolean in wpf binding scenarios (used in 'IsEnabled' for example)
- fixed the relevant tests following the change
- show 'blank' instead of 'Select Types' - default display text changed
- amended resources
- fixed a bug where incompatible lists would be allowed
- added test to check all error conditions
- code cleanup
Copy link

github-actions bot commented May 21, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

dnenov added 3 commits May 22, 2024 13:15
- replaced playervalue with the node value property
- added a function to safely extract the dictionary value from the dictionary we prepare for the AST
@dnenov dnenov changed the title Definedata bugfix heterogenous lists DYN-6633: Definedata bugfix heterogenous lists May 22, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633

@twastvedt twastvedt merged commit f2486d1 into DynamoDS:master May 22, 2024
27 of 28 checks passed
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
Co-authored-by: Trygve Wastvedt <[email protected]>
Co-authored-by: Trygve Wastvedt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants