-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6633: Definedata bugfix heterogenous lists #15235
Merged
twastvedt
merged 10 commits into
DynamoDS:master
from
dnenov:definedata-bugfix-heterogenous-lists
May 22, 2024
Merged
DYN-6633: Definedata bugfix heterogenous lists #15235
twastvedt
merged 10 commits into
DynamoDS:master
from
dnenov:definedata-bugfix-heterogenous-lists
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update to ui to match latest design intent - removed redundant code - introduced new `BooleanNegationConverter` (how was that not needed before) to flip the value of a boolean in wpf binding scenarios (used in 'IsEnabled' for example)
- fixed the relevant tests following the change - show 'blank' instead of 'Select Types' - default display text changed
- fixed a bug where incompatible lists would be allowed - added test to check all error conditions - code cleanup
UI Smoke TestsTest: success. 2 passed, 0 failed. |
- replaced playervalue with the node value property
- added a function to safely extract the dictionary value from the dictionary we prepare for the AST
…-heterogenous-lists
dnenov
changed the title
Definedata bugfix heterogenous lists
DYN-6633: Definedata bugfix heterogenous lists
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633
twastvedt
approved these changes
May 22, 2024
Enzo707
pushed a commit
to Enzo707/Dynamo
that referenced
this pull request
May 22, 2024
Co-authored-by: Trygve Wastvedt <[email protected]> Co-authored-by: Trygve Wastvedt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@twastvedt
@mjkkirschner
@saintentropy
FYIs
@Amoursol