Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6990 Crash when selecting node with view extension #15231

Merged
merged 1 commit into from
May 20, 2024

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented May 20, 2024

Purpose

This PR handles the crash described in https://jira.autodesk.com/browse/DYN-6990,
the crash seems to occur when the user tried make a selection of node(s), the main issue could be related an action performed with monocle extension. I was not able to re-produce the crash in Dynamo 3.0.3, the version of monocle used is not provided but I tried with 2024.5.1.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix crash when selecting node with view extension

Reviewers

@DynamoDS/dynamo

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6990

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.2 milestone May 20, 2024
@QilongTang
Copy link
Contributor

@zeusongit
Copy link
Contributor Author

One regression? DynamoCoreWpfTests.DynamoViewTests.OpeningWorkspaceWithTclsrustWarning

Saw that, it is passing locally, so I have triggered a rebuild

@zeusongit
Copy link
Contributor Author

Build passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16051/, the one test failing before probably was a fluke, merging.

@zeusongit zeusongit merged commit fa05e22 into DynamoDS:master May 20, 2024
25 of 27 checks passed
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants