-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6633: Define Data node revisions #15229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633
UI Smoke TestsTest: success. 2 passed, 0 failed. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, a lot of simplifications to the code! Quite a few new ways of doing things. Everything looks good, only one idea - do you think we could rename 'IsAutoMode' to something better suited with the new 'Auto-detect' paradigm?
Purpose
IsSupportedDataNodeType
toEvaluateDefineDataNode
for clarity.EvaluateDefineDataNode
as Obsolete to indicate it may change (needs to be public for AST)DefineDataNodeViewCustomization
andDataNodeDynamoType
internal.Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of