Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas #15224

Merged
merged 5 commits into from
May 17, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 16, 2024

Purpose

per DYN-6967 Crash when placing List selector archi-lab Dynamo nodes in canvas. This could happen when nodes from 3rd party in package crash at node constructor.

Example crash stacktrace

Could not load file or assembly 'Microsoft.Practices.Prism, Version=4.1.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

   at archilabUI.ListSelector.ListSelector..ctor()
   at lambda_method661(Closure)
   at Dynamo.Search.SearchElements.NodeModelSearchElement.ConstructNewNodeModel()
   at Dynamo.Search.SearchElements.NodeSearchElement.CreateNode()
   at Dynamo.Wpf.ViewModels.NodeSearchElementViewModel.OnClicked()
   at Prism.Commands.DelegateCommand.Execute()
   at Prism.Commands.DelegateCommand.Execute(Object parameter)
   at Prism.Commands.DelegateCommandBase.System.Windows.Input.ICommand.Execute(Object parameter)
   at Dynamo.UI.Controls.InCanvasSearchControl.ExecuteSearchElement(ListBoxItem listBoxItem)
   at Dynamo.UI.Controls.InCanvasSearchControl.OnMouseLeftButtonUp(Object sender, MouseButtonEventArgs e)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix a crash when placing List selector archi-lab Dynamo nodes in canvas, Dynamo would crash and show crash report dialog. This crash currently can only be fixed by package author.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6967

Copy link

github-actions bot commented May 16, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.2 milestone May 17, 2024
@QilongTang
Copy link
Contributor Author

@QilongTang
Copy link
Contributor Author

@QilongTang QilongTang merged commit fd7d21b into master May 17, 2024
23 of 24 checks passed
@QilongTang QilongTang deleted the CreatingNodeCrash branch May 17, 2024 17:51
Enzo707 pushed a commit to Enzo707/Dynamo that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants