Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6857 homepage settings refactor #15223

Merged
merged 1 commit into from
May 17, 2024

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented May 16, 2024

Purpose

Simplification of the way HomePage settings were serialized as part of the Dynamo Preferences. No longer maintains a Dictionary<string, object> but uses List<string> instead.

Formerly, a workaround was created to serialize a json-serialized version of the Dictionary, as the limitation is that xaml cannot serialize Dictionary types.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • no longer serializes to Dictionary, but list of ':' delimited key/value pairs
  • adjusted all affected Tests and resources

Reviewers

@QilongTang
@reddyashish

FYIs

- no longer serializes to Dictionary, but list<string> of ':' delimited key/value pairs
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang requested a review from reddyashish May 16, 2024 15:12
@QilongTang QilongTang changed the title homepage settings refactor DYN-6857 homepage settings refactor May 16, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6857

@QilongTang QilongTang added this to the 3.2 milestone May 17, 2024
@QilongTang QilongTang merged commit 3df920e into DynamoDS:master May 17, 2024
35 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants