Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6934 Address edge case where placing custom node would send Guid instead of node name as analytics #15213

Merged
merged 1 commit into from
May 14, 2024
Merged

DYN-6934 Address edge case where placing custom node would send Guid instead of node name as analytics #15213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/DynamoCore/Models/RecordableCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,10 +1003,16 @@ protected override void SerializeCore(XmlElement element)

internal override void TrackAnalytics()
{
Dynamo.Logging.Analytics.TrackEvent(
Logging.Actions.Create,
Logging.Categories.NodeOperations,
(Node != null) ? Node.GetOriginalName() : Name ?? "");
// For custom nodes, Node is null until the node has been created
// Including the custom node cases should not be encouraged since
// GetOriginalName() will return the Guid of custom node
if (Node != null)
{
Logging.Analytics.TrackEvent(
Logging.Actions.Create,
Logging.Categories.NodeOperations,
Node.GetOriginalName() ?? string.Empty);
}
}

#endregion
Expand Down
Loading