Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6816 Update Dynamo Home Version #15210

Merged
merged 1 commit into from
May 13, 2024
Merged

DYN-6816 Update Dynamo Home Version #15210

merged 1 commit into from
May 13, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 13, 2024

Purpose

Per https://jira.autodesk.com/browse/DYN-6816, update the version of Dynamo Home package again to include more localized resources.

The following is simplified Chinese

image image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Dynamo Home experience now will be localized on the web component level which is independent of Dynamo localization experience.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6816

@QilongTang
Copy link
Contributor Author

The open and new button remains English for now and is pending a change from @dnenov to include in the localization process.

@QilongTang
Copy link
Contributor Author

@sm6srw Should we update the PR template so ppl know the requirement of Release notes must have at least 6 words?

@QilongTang QilongTang merged commit 1e79ba7 into master May 13, 2024
25 of 29 checks passed
@QilongTang QilongTang deleted the DynamoHomeVersion branch May 13, 2024 17:36
@QilongTang
Copy link
Contributor Author

Known sporadic failure on master-5 only, merging

@QilongTang QilongTang added this to the 3.2 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants