DYN-6893 input symbol nodes should have default names - pt 1 #15193
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
|
||
| InputSymbol = String.Empty; | ||
| //TODO localize | ||
| InputSymbol = new TypedParameter($"DefaultInputName", "var",-1,null).ToCommentNameString(); |
There was a problem hiding this comment.
So by default all input nodes will have the same name ?
so by default all input names of a custom node will have the same name. Do you think it might be worth create a unique name ?...maybe not
Also do output nodes not have the same issue ?
There was a problem hiding this comment.
So by default all input nodes will have the same name ? - yes
so by default all input names of a custom node will have the same name - yes - but note that there should not be inputNodes in home workspaces.
yes, by default they will have the same name, I considered using a part of the node guid so there's a very high chance the name would be unique - ie InputName_12345 or something like that.
Something to consider is that today, they already have the same name, it's just "".
Output nodes do not have any validation as far as I can tell.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6893
Purpose
When a user creates a
input node(also known as a symbol node) in a custom node workspace previously the input node was empty. If left in this state and saved, the input symbol would be invalid as it did not have a default name, and would raise a warning and disallow save when next opened.Just for the curious the input does have a default type though
(var[]..[]).To address this issue - now when an
Input nodeis constructed now we set the name to a default (I'm just usinginputfor now, which is what we use as a display name when the name is empty)We now also show the type hint in default string to make the syntax more discoverable, as well as a comment - we could also show the default value syntax easily enough but I thought that might be info overload, as well as potentially having unintended consequences.
before:
after:
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
By default creating inputs in a custom node will not put the custom node into an invalid state.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
@Jingyi-Wen thoughts on this approach or what the default name / default string should be?