DYN-6769 improving dynamo load graph ii 2 #15158
Conversation
* DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore. * DYN-6769 Improving Dynamo Load Graph With this change only will be executing the DefaultAutocompleteCandidates functionality only once at Dynamo startup and when a graph is loaded won't be executed anymore.
Instead of using a static Dictionary now I will be using a normal instance that will be initialized in DynamoViewModel and pass it to NodeAutoCompleteSearchViewModel, in this case we are also confirming that only be executed once.
Disabling the DefaultNodeAutocomplete functionality when Dynamo is in ServiceMode.
|
GIF showing that the Node Autocomplete functionality is working. |
|
Also I've run this changes in the DYN-DevCI_Self_Service job and all tests are passing. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
| var queries = new List<string>() { "String", "Number Slider", "Integer Slider", "Number", "Boolean", "Watch", "Watch 3D", "Python Script" }; | ||
| foreach (var query in queries) | ||
| { | ||
| var foundNode = tempSearchViewModel.Search(query).Where(n => n.Name.Equals(query)).FirstOrDefault(); |
There was a problem hiding this comment.
Do we have to call the search API from tempSearchViewModel, just curious if this object intialization can be skipped?
There was a problem hiding this comment.
Well, my idea was to get the nodes for DefaultNodeAutocomplete at DynamoViewModel level and then pass them to the NodeAutoCompleteSearchViewModel instance (so in this way the search will be executed once per each node).
If you remember at Dynamo startup we create one DynamoViewModel but inside this we are creating two WorkpaceViewModel instances and inside each instance we are creating the NodeAutoCompleteSearchViewModel instance and the SearchViewModel instance, so the SearchViewModel instance is at WorkpaceViewModel level that's why I had to create the tempSearchViewModel instance (SearchViewModel) at DynamoViewModel level (we don't have that instance at that level) otherwise I won't be able to execute the Search for each node.
Let me know if it sounds clear to you or otherwise I can make a diagram showing the details.
Thanks
|
By the way I can see the Dynamo SelfServe check failed due to the next test. But I executed the same branch in the DYN-DevCI_Self_Service job two times and both passed. |
|
@RobertGlobant20 can you mark that test as failure on master branch. It has been marked on 3.1 branch but forgot to make that change on master. |
Marking the test RemovePIIDataFromWorkspace as Failure
done in the next commit: 4d348f3 |
Purpose
Modifying the DefaultNodeAutocompleteCandidates functionality so is only executed once.
Instead of using a static Dictionary now I will be using a normal instance that will be initialized in DynamoViewModel and pass it to NodeAutoCompleteSearchViewModel, in this case we are also confirming that only be executed once.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Modifying the DefaultNodeAutocompleteCandidates functionality so is only executed once.
Reviewers
@QilongTang
FYIs