Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6864 undo renaming and collapsing group #15151

Conversation

ivaylo-matov
Copy link
Contributor

Purpose

PR to address DYN-6864
Undo group collapsing as well as renaming. Includes test.

DYN-6864_fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

PR to address DYN-6864
Undo group collapsing as well as renaming.
Please note that the first click on renaming is recorded to the Undo stack as selection so undo renaming requires two clicks. This is existing condition. Usure if it should be changed.
Includes test.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

Copy link

github-actions bot commented Apr 17, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@avidit avidit changed the title Dyn 6864 undo renaming and collapsing group DYN-6864 undo renaming and collapsing group Apr 29, 2024
@reddyashish reddyashish marked this pull request as ready for review April 29, 2024 19:30
@QilongTang QilongTang added this to the 3.2 milestone Apr 30, 2024
@ivaylo-matov
Copy link
Contributor Author

sorry, will try to resolve this today or over the weekend

should resolve the issue with regressions in GraphLayoutTests
@ivaylo-matov
Copy link
Contributor Author

@QilongTang that should fix the regressions 🤞

@reddyashish
Copy link
Contributor

Tests passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/15987/. Harmony stage has failed but that doesn't seem related to this.

@reddyashish reddyashish merged commit a8b023d into DynamoDS:master May 6, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants