-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6864 undo renaming and collapsing group #15151
Merged
reddyashish
merged 8 commits into
DynamoDS:master
from
ivaylo-matov:DYN-6864-Undo-renaming-and-collapsing-group
May 6, 2024
Merged
DYN-6864 undo renaming and collapsing group #15151
reddyashish
merged 8 commits into
DynamoDS:master
from
ivaylo-matov:DYN-6864-Undo-renaming-and-collapsing-group
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first draft - works but needs cleaning
UI Smoke TestsTest: success. 2 passed, 0 failed. |
avidit
changed the title
Dyn 6864 undo renaming and collapsing group
DYN-6864 undo renaming and collapsing group
Apr 29, 2024
reddyashish
approved these changes
Apr 29, 2024
sorry, will try to resolve this today or over the weekend |
should resolve the issue with regressions in GraphLayoutTests
@QilongTang that should fix the regressions 🤞 |
Tests passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/15987/. Harmony stage has failed but that doesn't seem related to this. |
reddyashish
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PR to address DYN-6864
Undo group collapsing as well as renaming. Includes test.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
PR to address DYN-6864
Undo group collapsing as well as renaming.
Please note that the first click on renaming is recorded to the Undo stack as selection so undo renaming requires two clicks. This is existing condition. Usure if it should be changed.
Includes test.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol