DYN-6678 integer slider improvement. #15093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
commented
Apr 5, 2024
| { | ||
| var invariantString = formattableval.ToString(null,CultureInfo.InvariantCulture); | ||
| model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), invariantString)); | ||
| var sliderValue = Math.Round(decimal.Parse(invariantString), decimalPoints); | ||
| model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), sliderValue.ToString())); | ||
| } | ||
| else | ||
| { |
There was a problem hiding this comment.
Does anyone know in which case the else block here gets triggered? I am thinking if we should round the value there as well?
There was a problem hiding this comment.
I can't think of any. I believe int, float, double, long, are all IFormattable.
UI Smoke TestsTest: success. 2 passed, 0 failed. |
QilongTang
approved these changes
Apr 8, 2024
QilongTang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Task: https://jira.autodesk.com/browse/DYN-6678
Consistent precision on the number slider, by considering the step value of the slider.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Consistent precision on the number slider when using the slider.
Reviewers
@QilongTang @zeusongit