Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6619-Localizing Stream Writer Exception2 #15041

Merged
merged 2 commits into from
Mar 25, 2024
Merged

DYN-6619-Localizing Stream Writer Exception2 #15041

merged 2 commits into from
Mar 25, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Localizing System StreamWriter exception
I've done the Resources internal so probably will be fixing the MarkdownGeneratorCommand regression.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Localizing System StreamWriter exception

Reviewers

@QilongTang

FYIs

RobertGlobant20 and others added 2 commits March 19, 2024 16:54
Localizing System StreamWriter exception
Localizing System StreamWriter exception
@QilongTang QilongTang added this to the 3.1 milestone Mar 25, 2024
@QilongTang QilongTang merged commit 765542d into DynamoDS:master Mar 25, 2024
21 of 22 checks passed
QilongTang pushed a commit that referenced this pull request Apr 5, 2024
QilongTang pushed a commit that referenced this pull request Apr 9, 2024
* Revert "DYN-6619-Localizing Stream Writer Exception2 (#15041)"

This reverts commit 765542d.

* Revert "DYN-6619-Localizing Stream Writer Exception2 (#15041)" (#15092)

This reverts commit 765542d.

* homepage links fix

- fixes homepage links
- this was broken during the drag&drop implementation

* revert rebased changes

* revert resources rebase

---------

Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Roberto T <[email protected]>
QilongTang added a commit that referenced this pull request Apr 16, 2024
* Revert "DYN-6619-Localizing Stream Writer Exception2 (#15041)"

This reverts commit 765542d.

* Revert "DYN-6619-Localizing Stream Writer Exception2 (#15041)" (#15092)

This reverts commit 765542d.

* base64 img for tour guides

- added base64 img for tour guides as resources to be used as thumbnails in the HomePage

* Update PublicAPI.Unshipped.txt

* revert rebased changes

* revert rebase resources

* moved resources to HomePage class

- moved base64 image resources to the HomePage class

* Update PublicAPI.Unshipped.txt

---------

Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Roberto T <[email protected]>
Co-authored-by: Aaron (Qilong) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants