Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6187: Dash in the middle of a sentence should not be converted to bullet point #14996

Merged
merged 3 commits into from
Mar 8, 2024
Merged

DYN-6187: Dash in the middle of a sentence should not be converted to bullet point #14996

merged 3 commits into from
Mar 8, 2024

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Mar 4, 2024 •
edited by dnenov
Loading

Purpose

Small PR that fixes a bug which converts dash to bullet point in the middle of a Note line if a bullet point has been used previously in the text of the Note.

The PR addresses the following Jira issue: https://jira.autodesk.com/browse/DYN-6187

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Dash in the middle of a sentence should not be converted to bullet

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

@ivaylo-matov
Dash in the middle of a sentence should not be converted to bullet
39ccde5 
Dash in the middle of a sentence should not be converted to bullet.
@ivaylo-matov
Dash in the middle of a line
0a0fc98 
Dash in the middle of a sentence should not be converted to bullet.
@ivaylo-matov
Dash in the middle of a line
4ff64a8 
Dash in the middle of a sentence should not be converted to bullet.
@ivaylo-matov ivaylo-matov marked this pull request as ready for review March 4, 2024 16:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang requested a review from dnenov March 6, 2024 04:45
@dnenov dnenov changed the title Dash in the middle of a sentence should not be converted to bullet point DYN-6187: Dash in the middle of a sentence should not be converted to bullet point Mar 8, 2024
dnenov
dnenov reviewed Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@dnenov dnenov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - build on my end, the fix addresses the issue.

@QilongTang QilongTang added this to the 3.1 milestone Mar 8, 2024
@QilongTang QilongTang merged commit b3ac50a into DynamoDS:master Mar 8, 2024
21 checks passed
@avidit avidit mentioned this pull request Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnenov dnenov dnenov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ivaylo-matov @dnenov @QilongTang