-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-6653 Create new workspace based on Templates - Part II #14982
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
@@ -2615,6 +2659,9 @@ public void ShowSaveDialogAndSaveResult(object parameter) | |||
if (_fileDialog.ShowDialog() == DialogResult.OK) | |||
{ | |||
SaveAs(_fileDialog.FileName); | |||
LastSavedLocation = Path.GetDirectoryName(_fileDialog.FileName); | |||
//set the IsTemplate to false, after saving it as a file | |||
vm.Model.CurrentWorkspace.IsTemplate = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments
@@ -1537,28 +1562,6 @@ private void InitializeCommands() | |||
CopyToClipboardCommand = new DelegateCommand(p => CopyToClipboard(p)); | |||
} | |||
|
|||
public bool UpdateBackupLocation(string newBackupLocation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be a API break as the class is public too.
} | ||
} | ||
|
||
public void ResetBackupLocation() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same APi break.
4 Errors in the API checks |
Merging, API break analysis failures have been fixed and build passed earlier. |
Purpose
ToDo:
Short cut key combo Ctrl + T does not work yet(changed to Ctrl+Shift+O as per VS standards for open menu)This PR:
adds a new hotkey to open templates:
Ctrl+Shift+O
(FYI @Amoursol, Ctrl+T has a conflict)adds the template location as a preference setting, can be updated or reset by the user.
When saving a file opened from template the save dialog will be pointed to the last accessed location by the user that is not the templates directory, if null, will be redirected to Desktop.
(In the screen capture below, the template is opened on first use, some changes are made and while saving the last accessed location was null, so Desktop was the default location)
When opening a graph after opening a template, the open dialog will
(In the screen capture below, a file is opened from a random location, then a template is opened, after some changes while saving the template, the last accessed location is opened by default, not the template directory)
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@DynamoDS/dynamo