Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6603 decrease weight for tspline nodes #14965

Merged
merged 3 commits into from
Feb 27, 2024
Merged

DYN-6603 decrease weight for tspline nodes #14965

merged 3 commits into from
Feb 27, 2024

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Decreasing t-spline nodes weight during search so we will see nodes under a specific category at the top and later t-spline nodes.
I've changed the weight of Spline nodes at indexing time so when using criteria like "sphere" will show first the nodes under the Sphere category and later the T-Spline nodes which has the text "sphere" in the name. For implementing the expected behavior I've decreased the weight of the fields Description and SearchKeywords just for t-spline nodes.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Decreasing t-spline nodes weight during search so we will see nodes under a specific category at the top and later t-spline nodes.

Reviewers

@QilongTang @reddyashish

FYIs

I've changed the weight of Spline nodes at indexing time so when using criteria like "sphere" will show first the nodes under the Sphere category and later the T-Spline nodes which has the text "sphere" in the name.
For implementing  the expected behavior I've decreased the weight of the fields Description and SearchKeywords just for t-spline nodes.
@RobertGlobant20
Copy link
Contributor Author

Screenshot showing results before and after my fix:
image

@RobertGlobant20
Copy link
Contributor Author

Screenshot showing results before and after my fix:
image

Copy link

github-actions bot commented Feb 23, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Feb 23, 2024
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, can you add a unit test about the order of a geometry search results?

I've added a unit test that will validate the nodes result order after searching a specific criteria which includes in the results T-Spline nodes.
@RobertGlobant20
Copy link
Contributor Author

Thanks, looks good, can you add a unit test about the order of a geometry search results?

@QilongTang I've added a unit test that will validate the order of nodes (when t-spline nodes were added).
commit: aa45115

@QilongTang QilongTang merged commit fc9f5f2 into DynamoDS:master Feb 27, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants