DYN-6664: Fix crash when no asm is found. #14958
Conversation
UI Smoke TestsTest: success. 2 passed, 0 failed. |
| { | ||
| handler(new WorkspacesSettingsChangedEventArgs(enableLegacyPolyCurveBehavior)); | ||
| } | ||
| catch (NullReferenceException) |
There was a problem hiding this comment.
what is null in this case?
There was a problem hiding this comment.
is it hard to add a test for this? I would not have expected this to need a try catch.
There was a problem hiding this comment.
Something inside LibG because ASM is missing. I think this fix is the best one for 3.0.4 as I don't think we want to add paneling in 3.0.4. That being said, for master, I could go ahead and fix this in LibG and then remove this try/catch when the new LibG version with that fix is integrated.
There was a problem hiding this comment.
I think mGeometryFactory is null in this line when ASM is not found.
Purpose
DYN-6664: Fix crash when no asm is found.
A crash still happens when a Dyn file is opened when no ASM is found. This can also be fixed in LibG but fixing it here simplifies the removal of ASM229 in 3.0.4 (where we have no panelling support). This fix works for all version of LibG for ASM230.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of