PM single warning message on existing dll loading #14890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- trigger warning message only once when the user has attempted to load an existing dll from another path
reddyashish
approved these changes
Jan 26, 2024
|
Can we add a test for this? |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
@QilongTang Cherrypick this into 3.0.3 once the self-serve passes here? |
|
@reddyashish Sure |
reddyashish
pushed a commit
to reddyashish/Dynamo
that referenced
this pull request
Jan 26, 2024
- trigger warning message only once when the user has attempted to load an existing dll from another path (cherry picked from commit abbd28f)
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Jan 26, 2024
- trigger warning message only once when the user has attempted to load an existing dll from another path (cherry picked from commit abbd28f) Co-authored-by: Deyan Nenov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A small change to the warning dialog only to show up once when the user has attempted to load an existing dll from another path.
Fix
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@reddyashish
@Amoursol
FYIs