[DYN-6621] Save "Don't show again" setting on splash screen close #14866
Conversation
zeusongit
changed the title
UI Smoke TestsTest: success. 2 passed, 0 failed. |
| @@ -600,9 +605,9 @@ public bool SignOut() | |||
| { | |||
| return RequestSignOut(); | |||
| } | |||
| public void CloseWindow() | |||
| public void CloseWindow(bool isCheckboxChecked) | |||
There was a problem hiding this comment.
Are any of these API used in Dynamo Revit repo?
There was a problem hiding this comment.
Also instead of passing param, any other way to do it, e.g. static boolean saved?
There was a problem hiding this comment.
Are any of these API used in Dynamo Revit repo?
The APIs are not used in DynamoRevit
| @@ -604,5 +628,9 @@ public void CloseWindow() | |||
| { | |||
| RequestCloseWindow(); | |||
| } | |||
| public void CloseWindowPreserve(bool isCheckboxChecked) | |||
There was a problem hiding this comment.
The overload does not seem to work in Javascript context, I am getting this error: Invalid number of parameters in console. It is probably getting confused or maybe overloads don’t work in script object. The other solution is to use a new method. I have update the PR please take a look. @QilongTang
UI Smoke TestsTest: success. 2 passed, 0 failed. |
…namoDS#14866) * Update SplashScreen.xaml.cs * Update SplashScreen.xaml.cs
…4866) (#15018) * Update SplashScreen.xaml.cs * Update SplashScreen.xaml.cs Co-authored-by: Ashish Aggarwal <[email protected]>
Purpose
https://jira.autodesk.com/browse/DYN-6621
If the "Don't show again" option on the splash screen is checked while closing it from the splash screen close button, the setting will be saved and the splash screen will not pause on the next run.
SplashScreen PR: DynamoDS/SplashScreen#49
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
@DynamoDS/dynamo