Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove retain folder structure option during package publish #14813

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

mjkkirschner
Copy link
Member

Purpose

Removes the retain folder structure option during package publish as it does not yet fully work as intended.
https://jira.autodesk.com/browse/DYN-6589 has been filed to re enable it in the future.

toggle is removed from this view.

Screenshot 2024-01-04 at 4 15 48 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

removes retain folder structure option until it's fully baked.

@mjkkirschner mjkkirschner added this to the 3.0.2 milestone Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@hwahlstrom
Copy link
Collaborator

If this toggle is removed, we should also remove the section in the package documentation help (in the doc browser) that explains this setting.

@mjkkirschner
Copy link
Member Author

If this toggle is removed, we should also remove the section in the package documentation help (in the doc browser) that explains this setting.

Hi @hwahlstrom how does a user access that documentation?

@QilongTang
Copy link
Contributor

@mjkkirschner You will need to build latest master or RC3.0.1 to access it because it was just restored:
image

Copy link

github-actions bot commented Jan 9, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@mjkkirschner
Copy link
Member Author

test runner is still crashing, so not sure if theres any failures here or not, holding off on merging until I get a passing build - then will cherry pick to 3.0.2

@mjkkirschner
Copy link
Member Author

mjkkirschner commented Jan 11, 2024

this passed on master-15, but the test system is still flaky (runner crashes) - @QilongTang @sm6srw I'm going to merge this and send a cherry pick - but please feel free to revert this PR if it seems to increase the frequency of test runner crashes or slows down the release process.

@mjkkirschner mjkkirschner merged commit 3354472 into DynamoDS:master Jan 12, 2024
20 of 21 checks passed
@mjkkirschner mjkkirschner deleted the rem-retain branch January 12, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants