Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-2] Fix Graphic Scale Units dropdown localization #14810

Merged
merged 30 commits into from
Jan 8, 2024

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jan 4, 2024

Purpose

When a new locale is selected the dropdown was blank as it was not able to match the selected value to the new localized menu items.

Screenshot 2024-01-04 at 1 57 11 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix-2 Fix Graphic Scale Units dropdown localization

Reviewers

@avidit

@zeusongit zeusongit requested review from avidit and QilongTang January 4, 2024 18:55
@zeusongit zeusongit marked this pull request as ready for review January 4, 2024 18:56
@zeusongit zeusongit changed the title Fix-#2 Fix Graphic Scale Units dropdown localization Fix-2 Fix Graphic Scale Units dropdown localization Jan 4, 2024
@zeusongit zeusongit changed the title Fix-2 Fix Graphic Scale Units dropdown localization [Fix-2] Fix Graphic Scale Units dropdown localization Jan 4, 2024
Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.0.1 milestone Jan 4, 2024
@zeusongit zeusongit mentioned this pull request Jan 5, 2024
9 tasks
@QilongTang
Copy link
Contributor

Validated in 3.0.1 build

@QilongTang QilongTang merged commit dc38712 into DynamoDS:master Jan 8, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants