Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-6577][DYN-6548] Fix Publish current workspace option and PM documentation link #14808

Merged
merged 31 commits into from
Jan 8, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

This PR addresses https://jira.autodesk.com/browse/DYN-6548 and https://jira.autodesk.com/browse/DYN-6577.

  • Fixed the unresponsive Publish Current Workspace option, now a message box is displayed to the user if they try to publish an unsaved custom node workspace.
    Screenshot 2024-01-03 at 2 45 43 PM

  • Added a info icon to Package Manager window to display new package manager help documentation which was also updated as per the refresh.
    Screenshot 2024-01-03 at 3 39 23 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fixed Publish Current Workspace option
  • Added PM help documentation link

Reviewers

Copy link

github-actions bot commented Jan 3, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit zeusongit requested a review from QilongTang January 4, 2024 16:09
@zeusongit zeusongit marked this pull request as ready for review January 4, 2024 16:09
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just checking if the UX team reviewed the PM documentation changes.

@QilongTang QilongTang added this to the 3.0.1 milestone Jan 4, 2024
@zeusongit
Copy link
Contributor Author

LGTM, just checking if the UX team reviewed the PM documentation changes.

Yes the documentation was provided by @hwahlstrom

@hwahlstrom
Copy link
Collaborator

Could we update the tooltip too for package manager help? Change Learn More about publishing a package to Learn more about packages

@zeusongit
Copy link
Contributor Author

Could we update the tooltip too for package manager help? Change Learn More about publishing a package to Learn more about packages

Done.

Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit zeusongit mentioned this pull request Jan 5, 2024
9 tasks
@QilongTang
Copy link
Contributor

Validated in 3.0.1 build

@QilongTang QilongTang merged commit cf3fa97 into DynamoDS:master Jan 8, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants