Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYN-5194] feature (NotificationsCenter): disable link reference tooltip #14807

Conversation

Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Dec 29, 2023

Purp

4BC75EB8-BD1B-4E19-AD34-19225D81C365
ose

Ref.: DYN-5194
This PR disable link reference tooltip for notificationsCenter webview component.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Set NotificationsCenter's Webview.IsStatusBarEnabled property to false.

Reviewers

@avidit

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.1 milestone Jan 3, 2024
@reddyashish
Copy link
Contributor

The jira task says it should open the link in the external browser, did the AC change?

@QilongTang QilongTang merged commit 1f2e05a into DynamoDS:master Jan 4, 2024
20 of 21 checks passed
@QilongTang
Copy link
Contributor

The jira task says it should open the link in the external browser, did the AC change?

Let's do some testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants