Dynamo ML data ingestion Pipeline Extension. #14749
Conversation
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
src/PackageDetailsViewExtension/PackageDetailsViewExtension.csproj
Outdated
Show resolved
Hide resolved
src/PackageDetailsViewExtension/PackageDetailsViewExtension.csproj
Outdated
Show resolved
Hide resolved
|
do we handle the |
| </dependentAssembly> | ||
| </assemblyBinding> | ||
| </runtime> | ||
| </configuration> |
There was a problem hiding this comment.
Why is this file needed?
|
We need to make sure the NoNetworkMode works on this new view extension |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: failure. 0 passed, 2 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Build error on action |
Fixed it now |
|
Triggered the job again. Also running the job on master15: https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1399/ |
|
Merge for testing and future performance improvements |
* commit * updates * updates * Update DynamoCoreWpf.csproj * Update DynamoCore.csproj * remove extra whitespaces * updates * updates * new changes * switch to prod * add to dynamocore.sln * Control by feature flag. * Update DynamoMLDataPipelineExtension.cs * Update DynamoMLDataPipelineExtension.cs * Update DynamoMLDataPipeline.csproj * Separating the extension code from core code and addressing comments. * Update DynamoMLDataPipeline.csproj * Update to feature flag and some comments * Fix Analytics reference error * Fix failing tests.
…14911) * Dynamo ML data ingestion Pipeline Extension. (#14749) * commit * updates * updates * Update DynamoCoreWpf.csproj * Update DynamoCore.csproj * remove extra whitespaces * updates * updates * new changes * switch to prod * add to dynamocore.sln * Control by feature flag. * Update DynamoMLDataPipelineExtension.cs * Update DynamoMLDataPipelineExtension.cs * Update DynamoMLDataPipeline.csproj * Separating the extension code from core code and addressing comments. * Update DynamoMLDataPipeline.csproj * Update to feature flag and some comments * Fix Analytics reference error * Fix failing tests. * Remove beta keyword * Make the test as failure --------- Co-authored-by: reddyashish <[email protected]>
| <?xml version="1.0" encoding="utf-8"?> | ||
| <configuration> | ||
| <appSettings> | ||
| <add key="StagingClientUrl" value="https://developer-stg.api.autodesk.com/exchange"/> |
There was a problem hiding this comment.
@reddyashish @QilongTang this file should not be here.
| </ProjectReference> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Reference Include="System" /> |
| <RootNamespace>DynamoMLDataPipeline</RootNamespace> | ||
| <AssemblyName>DynamoMLDataPipeline</AssemblyName> | ||
| <FileAlignment>512</FileAlignment> | ||
| <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects> |
There was a problem hiding this comment.
Removed. #15116
| <Reference Include="System.Xml" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="DynamoMLDataPipeline.cs" /> |
There was a problem hiding this comment.
totally unnecessary in sdk style, remove this.
There was a problem hiding this comment.
Removed. #15116
| <Compile Include="Properties\AssemblyInfo.cs" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <None Include="App.config" /> |
| namespace DynamoMLDataPipeline | ||
| { | ||
|
|
||
| internal class DynamoMLDataPipelineExtension : IExtension, IExtensionSource |
There was a problem hiding this comment.
why is this an IExtensionSource which throws not implemented?
There was a problem hiding this comment.
Forgot to remove this after some testing. Removed here: #15116
|
|
||
| public void Shutdown() | ||
| { | ||
| throw new NotImplementedException(); |
There was a problem hiding this comment.
these should be empty, they should not throw...
| namespace DynamoMLDataPipeline | ||
| { | ||
| // Schema and the assets for the data request body. | ||
| class UploadAssetsRequestBody |
There was a problem hiding this comment.
You really should use access modifiers to make this explicit, I think default is private.
There was a problem hiding this comment.
Default is internal for classes. Added internal modifier to these classes explicitly. #15116.
| public void Startup(StartupParams sp) | ||
| { | ||
| DynamoMLDataPipeline = new DynamoMLDataPipeline(); | ||
| DynamoMLDataPipeline.AuthTokenProvider = (IOAuth2AccessTokenProvider)sp.AuthProvider; |
There was a problem hiding this comment.
is this the only reason this extension exists?
There was a problem hiding this comment.
as opposed to being in an external process ? like the md2html.exe...
|
on @zeusongit's question, it seems no network mode was not handled? |
Will address it in the followup PR. Won't be affected by the current changes. Also will address the remaining comments in the followup PR for master branch. |
|
Is the purpose of this extension to strip sensitive data out of the dyn and send it to some cloud storage ? |
|
This extension is just sending the necessary dyn info to the Forge cloud storage, using restsharp API. No info is expected in the response, just an acknowledgement when it has successfully received. |
Purpose
Task: https://jira.autodesk.com/browse/DYN-6294.
We will be using Dynamo ML data ingestion pipeline as an extension inside Dynamo. It will be using the same restsharp 108.0.1 version only. This will be controlled by a feature flag and will be turned off for now.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of