Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Dyn-6060 - duplicate python engine names #14731

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix Dyn-6060 - duplicate python engine names #14731

merged 9 commits into from
Dec 12, 2023

Conversation

mjkkirschner
Copy link
Member

@mjkkirschner mjkkirschner commented Dec 11, 2023 •
edited
Loading

Purpose

This PR replaces:
mjkkirschner#5

  • cherry pick to 3.0

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

fix a bug where installing the ironPython package from the workspace references extension can add 2 ironPython items to the engine dropdown on python node.

Reviewers

@mjkkirschner
Copy link
Member Author

@pinzart90 said:

so if we will support assembly isolation, then we could have the same pacakge but different versions loaded at the same time
So should we enforce uniqueness by appending the version to the engine name (internally at least)?
In the UI we could display the same name but tooltip would clarify which version. Or something like that ..

IMO we can improve this later, but I think it's fine to request that Python engines use unique names and can definitely be deferred until we enforce assembly isolation somehow.

@mjkkirschner mjkkirschner added this to the 3.0 milestone Dec 11, 2023
@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@mjkkirschner
Copy link
Member Author

@pinzart90 @aparajit-pratap please take another look, I think all comments are resolved.

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@mjkkirschner mjkkirschner added the DNM Do not merge. For PRs. label Dec 12, 2023
@mjkkirschner
Copy link
Member Author

There are 900 test failures here, looking into it 😬

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions GitHub Actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@mjkkirschner mjkkirschner removed the DNM Do not merge. For PRs. label Dec 12, 2023
@mjkkirschner
Copy link
Member Author

The tests are fixed and they passed here:
https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1348/

I see some failures on master-5, but they don't seem to be related and they appear to just be new flakiness from moving to parallel tests - I see them on other PRs as well.

@mjkkirschner mjkkirschner merged commit 469642f into DynamoDS:master Dec 12, 2023
21 of 22 checks passed
@mjkkirschner mjkkirschner deleted the dyn6060 branch December 12, 2023 20:12
mjkkirschner added a commit to mjkkirschner/Dynamo that referenced this pull request Dec 12, 2023
@mjkkirschner
fix Dyn-6060 - duplicate python engine names (DynamoDS#14731)
e178173 
merging this and making a cherry pick.
@mjkkirschner mjkkirschner mentioned this pull request Dec 12, 2023
Merged
mjkkirschner added a commit that referenced this pull request Dec 13, 2023
@mjkkirschner
3.0 cherry pick DYN - 6060 (#14751)
2456c49 
* remove IronPython code and extension (#14706)

* remove legacy completion provider

* remove

* remove obsolete -arguable

tests seem to pass going to merge this and cherry pick to 3.0

* fix Dyn-6060 - duplicate python engine names (#14731)

merging this and making a cherry pick.
@mjkkirschner mjkkirschner mentioned this pull request Dec 13, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzart90 pinzart90 pinzart90 approved these changes

@aparajit-pratap aparajit-pratap Awaiting requested review from aparajit-pratap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkkirschner @pinzart90