more fixes for webview2 tests #14710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
pinzart90
commented
Dec 7, 2023
| else | ||
| { | ||
| viewModel?.MessageLogged?.Invoke(LogMessage.Info(message)); | ||
| } |
There was a problem hiding this comment.
some tests do not initialize one of MessageLogged field and so skip logging
mjkkirschner
approved these changes
Dec 7, 2023
mjkkirschner
reviewed
Dec 7, 2023
| viewModel.MessageLogged?.Invoke(LogMessage.Info(message)); | ||
| if (DynamoModel.IsTestMode) | ||
| { | ||
| System.Console.WriteLine(message); |
There was a problem hiding this comment.
does this actually make it into the test log?
saintentropy
pushed a commit
to saintentropy/Dynamo
that referenced
this pull request
Dec 9, 2023
Co-authored-by: pinzart <[email protected]> (cherry picked from commit d5e6c9b)
9 tasks
QilongTang
pushed a commit
that referenced
this pull request
Dec 11, 2023
* remove duplicate dyf file warning from preview generation process (#14711) - dynamo would issue a warning and fail to publish a package if an 'unqualified' file is being used, such as a dyf file already under package control - this check is done when publishing package locally, but I have incorrectly added it to the process of creating a build preview, which stops the process for both local and online submit workflow (cherry picked from commit 3ea1c5c) * update (#14710) Co-authored-by: pinzart <[email protected]> (cherry picked from commit d5e6c9b) * remove package version limitation (#14716) - now allows package version to start with 0 - cannot have 0.0.0 package version (cherry picked from commit 992e54c) * Localize menu items is Graphic Element Scale dropdown (#14714) * Fix PostDiff job * fix (cherry picked from commit 006113e) * remove dynamo sandbox app.config (#14713) * remove config * remove autogen stuff (cherry picked from commit 0947455) * DYN-6527: Fix graph update for primitive input nodes that are first initialized to null (#14703) * remove coreclr-ncalc references * add failing test for dropdown node * cleanup * update tests * attempt initial fix * cleanup * update test * review comments * add code comments (cherry picked from commit 8987869) --------- Co-authored-by: Deyan Nenov <[email protected]> Co-authored-by: pinzart90 <[email protected]> Co-authored-by: Ashish Aggarwal <[email protected]> Co-authored-by: Michael Kirschner <[email protected]> Co-authored-by: aparajit-pratap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased timeout for DoLoopEvents: as more and more test run, the thread queue gets congested and DoEvents takes longer and longer.
Some tests do not set the Logger properly in some Views, so I converted to COnsole.WriteLine during tests
MIssed one test that was initializing webview2