Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6493: reset page order when discarding publish package form #14695

Merged
merged 3 commits into from
Dec 6, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 5, 2023

Purpose

This PR addresses this jira issue https://jira.autodesk.com/browse/DYN-6493. When navigating away from the Publish tab, the UI now goes back to the first page (only when modifications were done and reset is performed).

reset page order

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • goes back to the first page when navigating away from the tab (on cancel only)

Reviewers

@reddyashish

FYIs

@avidit

- goes back to the first page when navigating away from the tab (on cancel only)
@dnenov dnenov changed the title reset page order DYN-6493: reset page order when discarding publish package form Dec 5, 2023
@QilongTang QilongTang added this to the 3.0 milestone Dec 6, 2023
@reddyashish reddyashish merged commit 0450cc0 into DynamoDS:master Dec 6, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants