Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-6454 Update smoke test workflow #14694

Merged
merged 2 commits into from
Dec 6, 2023
Merged

DYN-6454 Update smoke test workflow #14694

merged 2 commits into from
Dec 6, 2023

Conversation

avidit
Copy link
Contributor

@avidit avidit commented Dec 5, 2023 •
edited
Loading

Purpose

  • Set unique check name
  • Comment Pull request with UI smoke test result

screenshot 2023-12-05 at 3 32 32 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

sm6srw
sm6srw approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zeusongit zeusongit merged commit 51ec92c into DynamoDS:master Dec 6, 2023
21 checks passed
@zeusongit
Copy link
Contributor

Sorry @avidit for such a quick merge, confused it with a different approved PR. Revert if needed.

@avidit
Copy link
Contributor Author

avidit commented Dec 6, 2023

Sorry @avidit for such a quick merge, confused it with a different approved PR. Revert if needed.

No worries. It should be good. I will keep an eye out.

@avidit avidit deleted the feature/dyn-6454 branch December 6, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm6srw sm6srw sm6srw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avidit @zeusongit @sm6srw