Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6362 Refresh Packages Tour Bug #14693

Merged
merged 3 commits into from
Dec 7, 2023
Merged

DYN-6362 Refresh Packages Tour Bug #14693

merged 3 commits into from
Dec 7, 2023

Conversation

RobertGlobant20
Copy link
Contributor

Purpose

Bug reported by @avidit when testing the Packages Guide
I've added three validations for enabling the Dynamo UI when the Packages Tour is closed so in this way we will be preventing the UI Blocked bug.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Bug reported by @avidit when testing the Packages Guide

Reviewers

@QilongTang

FYIs

@avidit

I've added three validations for enabling the Dynamo UI when the Packages Tour is closed for preventing the UI Blocked bug.
@RobertGlobant20
Copy link
Contributor Author

GIF showing the Packages Tour
PackagesGuideBugFix

@QilongTang QilongTang added this to the 3.0 milestone Dec 6, 2023
@QilongTang
Copy link
Contributor

@RobertGlobant20 Please check regressions

@RobertGlobant20
Copy link
Contributor Author

@RobertGlobant20 Please check regressions

@QilongTang this are the tests failing but not sure why they could be related to the Package guide, basically my changes were in just two files GuidesManager.cs and GuidesValidationMethods.cs, then I will re-trigger the job just to see if they are still failing.

[DynamoCoreWpfTests.PackageManager.PackageManagerUITests.PackageManagerDownloadsBeforeInstalling
[DynamoCoreWpfTests.JSONSerializationTests.SerializationNonGuidIdsTest]
[DynamoCoreWpfTests.JSONSerializationTests.SerializationTest]

@QilongTang QilongTang merged commit 7c17a24 into DynamoDS:master Dec 7, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants