Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6500: disable cancel button if no changes #14692

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 5, 2023

Purpose

Addressing this jira https://jira.autodesk.com/browse/DYN-6500 issue. Disable the Cancel button if no changes are made to the current package publish form.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • if there are no changes, disable the cancel button
  • button renamed 'Cancel' to 'Reset'

Reviewers

@reddyashish

FYIs

@avidit

- if there are no changes, disable the cancel button
@dnenov dnenov changed the title disable cancel button of no changes DYN-6500: disable cancel button if no changes Dec 6, 2023
@reddyashish
Copy link
Contributor

@hwahlstrom Should we rename the cancel button here to reset button. This is the task: https://jira.autodesk.com/browse/DYN-6500

@hwahlstrom
Copy link
Collaborator

@reddyashish I commented in the Jira task: we could do Reset. If info has been entered, it should trigger the "Discard changes?" confirmation. Could we have an alternative version of the confirmation? It could say "Your changes will be lost if you proceed."

@reddyashish
Copy link
Contributor

@dnenov Can you change that? LGTM with that change.

@reddyashish reddyashish added this to the 3.0 milestone Dec 6, 2023
@dnenov
Copy link
Collaborator Author

dnenov commented Dec 6, 2023

Now renamed to 'Reset' guys!

@reddyashish reddyashish merged commit 6b64aee into DynamoDS:master Dec 6, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants