DYN-6842 Convert Helix instancing feature flag to a Preference Setting #14675
Conversation
…ancingOption # Conflicts: # src/DynamoCoreWpf/Properties/Resources.en-US.resx # src/DynamoCoreWpf/Properties/Resources.resx
| @@ -1971,8 +1970,7 @@ internal virtual void AggregateRenderPackages(IEnumerable<HelixRenderPackage> pa | |||
| //for each instancable item and add instance transforms. | |||
| //If we have any mesh geometry that was not associated with an instance, remove the previously added | |||
| //mesh data from the render package so the remaining mesh can be added to the scene. | |||
| if (rp.MeshVertexRangesAssociatedWithInstancing.Any() | |||
| && DynamoModel.FeatureFlags?.CheckFeatureFlag<bool>("graphics-primitive-instancing", false) == true) | |||
| if (rp.MeshVertexRangesAssociatedWithInstancing.Any()) | |||
There was a problem hiding this comment.
Why aren't you first checking if the useinstancing flag is on over here?
There was a problem hiding this comment.
Hey @aparajit-pratap this one is back.... So I think there is a question to be looked at here. In general we have fed preference level items that impact how something is tessellated in the TessellationParameters. Show Edges for example. We go Preferences -> TessellationParameters -> Tesselate -> Render. Render doesn't know about TessellationParameters. If we do the same here then the Render function should not be deciding to use Instancing... It should always use instancing if instancing data is present. The way the data in the RenderPackage works it actually might render everything wrong if it ignores the data associated with instancing since all the vertices are stored in the same array.
# Conflicts: # src/DynamoCoreWpf/Properties/Resources.en-US.resx # src/DynamoCoreWpf/Properties/Resources.resx
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
@saintentropy @aparajit-pratap Not sure what's the plan for this, I will move this to 3.1 milestone so we can close the 3.0 milestone on Github to wrap up the release. |
|
Hi @saintentropy @aparajit-pratap Please confirm this PR's state and Jira task? |
saintentropy
changed the title
Purpose
Convert the Helix Instancing feature flag to a Preference Setting.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of