Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libg and enable previously failing tests #14607

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Nov 14, 2023

Purpose

Update the LibG nuget version and update failing tests.

The updated LibG includes:

  • enhancements to json serialization
  • fix for visualization of oriented bounding boxes.
  • fix for instancing logic for rectangles and mirrored objects

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

NA

Reviewers

@mjkkirschner

FYIs

@LongNguyenP

@saintentropy
Copy link
Contributor Author

@QilongTang QilongTang added this to the 3.0 milestone Nov 14, 2023
@mjkkirschner mjkkirschner self-requested a review November 14, 2023 16:55
@saintentropy saintentropy merged commit 723cef6 into DynamoDS:master Nov 15, 2023
17 checks passed
@saintentropy saintentropy deleted the DYN-6898 branch November 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants