Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6339, DYN-6322 - honours filters during search #14591

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 10, 2023

Purpose

This PR fixes where filters would not be applied during the search when using the search packages in the Package Manager. Now the filters will be applied post-search and the results will be correctly filtered.

Addresses the following jira issues:

Workflow

honor filters

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now honors active filters while searching
  • refactor existing filter workflow

Reviewers

@avidit
@Jingyi-Wen
@reddyashish

FYIs

@Amoursol

- now honors active filters while searching
Copy link
Contributor

@reddyashish reddyashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

@reddyashish reddyashish added this to the 3.0 milestone Nov 10, 2023
@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit 8490918 into DynamoDS:master Nov 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants