Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6410 install my packages fix #14571

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 6, 2023

Purpose

Addressed a bug where packages under MyPackages section of the PM would not initiate an install. The issue is picked up in this jira thread: https://jira.autodesk.com/browse/DYN-6410

Changes

install my packages

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • fixed a bug where my package would not initiate an install
  • attached RequestDownload handler

Reviewers

@avidit
@reddyashish

FYIs

@Amoursol

- fixed a bug where my package would not initiate an install
- attached RequestDownload handler
@avidit avidit changed the title install my packages fix DYN-6410 install my packages fix Nov 6, 2023
@QilongTang QilongTang added this to the 3.0 milestone Nov 6, 2023
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 33acd1b into DynamoDS:master Nov 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants