Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm binding conversion error #14557

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 2, 2023

Purpose

A small PR addressing binding issues with the Numerical Up/Down custom user control.

This PR cherry-picks and updates some of the changes from #14506. The old one will be closed in favor of multiple smaller PRs.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • previously the dependency property of the numeric control was an integer, which would work, but would be raising a conversion error in the background

Reviewers

@reddyashish
@mjkkirschner

FYIs

@Amoursol

- previously the dependency property of the numeric control was an integer, which would work, but would be raising a conversion error in the background
@dnenov dnenov changed the title fix binding conversion error PM binding conversion error Nov 2, 2023
@dnenov dnenov changed the title PM binding conversion error Pm binding conversion error Nov 2, 2023
@dnenov dnenov mentioned this pull request Nov 2, 2023
9 tasks
@reddyashish reddyashish added this to the 3.0 milestone Nov 2, 2023
@QilongTang QilongTang merged commit 6c42a3c into DynamoDS:master Nov 2, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants