Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm multiple binding issues fix #14555

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 2, 2023

Purpose

Addressing multiple binding issues that were failing inside the PackageManager. The PM should not generate these binding errors following this PR.

This PR cherry-picks and updates some of the changes from #14506. The old one will be closed in favor of multiple smaller PRs.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • height offset conversion - removed
  • AmbiguousMatchException - caused by the extended PackageManagerSearchElementViewModel hiding the Model property inside the base class. Renaming to SearchElementModel solved the issue
  • refactor - created PackageManagerSearchElementViewModel property getters to allow the View to bind to the ViewModel, and not directly to the Model

Reviewers

@mjkkirschner
@reddyashish

FYIs

@Amoursol

@dnenov dnenov requested a review from reddyashish November 2, 2023 13:09
@dnenov dnenov mentioned this pull request Nov 2, 2023
9 tasks
@dnenov dnenov changed the title multiple binding issues fix Pm multiple binding issues fix Nov 2, 2023
@QilongTang QilongTang added this to the 3.0 milestone Nov 7, 2023
@reddyashish reddyashish merged commit 6252c4e into DynamoDS:master Nov 10, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants