Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6365 Promote Gate node from GD Extension to Dynamo Core. #14528

Merged
merged 8 commits into from
Nov 13, 2023

Conversation

saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Oct 28, 2023

Purpose

The purpose of the PR is to migrate the Gate Node from the GD Extension to Dynamo Core.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Dynamo now has the Gate node in the Out of the Box Library. The gate node allows you control the execution in sections of you graph. An open Gate passes data through unchanged. A closed Gate sends no data downstream.

Reviewers

@LongNguyenP @twastvedt

FYIs

@jnealb

Copy link
Contributor

@twastvedt twastvedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just copied from the extension - any changes from that code that require more careful inspection?

Also, can we consider an icon change? The icon looks to me like a circuit switch symbol, where "open" means no electricity flows through. Instead our terminology treats this node more like a fence gate: "open" means the cows flow through. Perhaps we could change the icon to something that reflects this? The description is, admittedly, clear, but I think many people's immediate instinct might be "incorrect" based on the icon.

@QilongTang QilongTang added this to the 3.0 milestone Oct 30, 2023
@saintentropy saintentropy merged commit 4971e9d into DynamoDS:master Nov 13, 2023
17 checks passed
@saintentropy saintentropy deleted the DYN-6365 branch November 13, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants