Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6308 : prioritize json over xaml #14477

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

BogdanZavu
Copy link
Contributor

@BogdanZavu BogdanZavu commented Oct 10, 2023

Purpose

Prioritize json loading over xaml loading.
A package with 100s of custom nodes (which is not that rare) will throw 100s of exceptions during loading.
This is a drag on performance and also pollutes the output window or log files.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

@BogdanZavu BogdanZavu requested a review from QilongTang October 10, 2023 14:02
@QilongTang QilongTang added this to the 3.0 milestone Oct 10, 2023
@QilongTang QilongTang merged commit 01ef5fc into DynamoDS:master Oct 10, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants